willbarrett commented on a change in pull request #8737: Migration and model 
changes to synchronize the data model
URL: 
https://github.com/apache/incubator-superset/pull/8737#discussion_r356183165
 
 

 ##########
 File path: superset/connectors/sqla/models.py
 ##########
 @@ -347,7 +347,7 @@ class SqlaTable(Model, BaseDatasource):
     owner_class = security_manager.user_model
 
     __tablename__ = "tables"
-    __table_args__ = (UniqueConstraint("database_id", "table_name"),)
+    __table_args__ = (UniqueConstraint("database_id", "schema", "table_name", 
name="_customer_location_uc"),)
 
 Review comment:
   Right. This is altering the model to match the table schema. Can you expand 
on what you see the problem to be? I'm not following what you mean from reading 
the referenced PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to