robdiciuccio commented on a change in pull request #8733: Replace
pandas.DataFrame with PyArrow.Table for nullable int typing
URL:
https://github.com/apache/incubator-superset/pull/8733#discussion_r356303320
##########
File path: tests/core_tests.py
##########
@@ -719,26 +721,11 @@ def test_mssql_engine_spec_pymssql(self):
(1, 1, datetime.datetime(2017, 10, 19, 23, 39, 16, 660000)),
(2, 2, datetime.datetime(2018, 10, 19, 23, 39, 16, 660000)),
]
- df = dataframe.SupersetDataFrame(
+ table = SupersetTable(
list(data), [["col1"], ["col2"], ["col3"]], MssqlEngineSpec
)
- data = df.data
- self.assertEqual(len(data), 2)
- self.assertEqual(
- data[0],
- {"col1": 1, "col2": 1, "col3": pd.Timestamp("2017-10-19
23:39:16.660000")},
- )
-
- def test_mssql_engine_spec_odbc(self):
Review comment:
Was thinking when I ripped this out that it was no longer necessary due to
transformations
[here](https://github.com/apache/incubator-superset/blob/master/superset/db_engine_specs/mssql.py#L64),
but it looks like additional transformation is required. cc @chinhngt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
