villebro commented on PR #44215: URL: https://github.com/apache/superset/pull/44215#issuecomment-6277293977
Rebased onto current master (the branch history is now a single commit, so the earlier SHAs such as f8ac8a3137 no longer exist; the content is unchanged). The inheritance helpers in `raise_for_access` now bind on the `(datasource_id, datasource_type)` match from #45002 (`_datasource_matches`), including the native-filter target (`datasetId` / `datasourceType`), the member-chart and multi-layer child legs, and the chart-viewer leg. The `allow_editorship` opt-out applies to the editor leg of the datasource branch. The `published` gate stays on the viewers leg only, so the editor-of-an-unpublished-dashboard case is still covered. Also added a test showing that embedded guests are excluded from the two `_promiscuous_viewer_inherits_*` helpers. @madhushreeag, could you take another look and re-approve if this looks right to you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
