willbarrett opened a new pull request #8814: Move function in utils folder to fix circular import issues URL: https://github.com/apache/incubator-superset/pull/8814 ### CATEGORY Choose one - [ ] Bug Fix - [ ] Enhancement (new features, refinement) - [X] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> A function in `superset/utils/core.py` had a circular import fix applied to it (required in utils/core due to it being depended on by the model layer) but it was only referenced in one place, in another `utils` file. Moving it to that file removes the need for the circular import fix. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TEST PLAN <!--- What steps should be taken to verify the changes --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @dpgaspar @craig-rueda
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
