nytai commented on a change in pull request #8845: [WIP] new, Dashboard list
view (react)
URL:
https://github.com/apache/incubator-superset/pull/8845#discussion_r360478957
##########
File path: superset/assets/tslint.json
##########
@@ -1,10 +1,11 @@
{
- "extends": ["tslint:recommended", "tslint-react"],
- "jsRules": {
- },
- "rules": {
- "interface-name" : [true, "never-prefix"],
- "quotemark": [true, "single"]
- },
- "rulesDirectory": []
-}
\ No newline at end of file
+ "extends": ["tslint:recommended", "tslint-react"],
+ "jsRules": {},
+ "rules": {
+ "interface-name": [true, "never-prefix"],
+ "quotemark": [true, "single"],
+ "jsx-no-multiline-js": false,
+ "jsx-no-lambda": false
Review comment:
We don't have these rules enabled in eslint and I found them to be very
tedious. Opened https://github.com/apache/incubator-superset/issues/8865 for
larger discussion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
