villebro commented on a change in pull request #8911: [dashboard] Fix, prevent
delete and update on dashes not owned
URL:
https://github.com/apache/incubator-superset/pull/8911#discussion_r362867378
##########
File path: superset/views/dashboard/api.py
##########
@@ -229,9 +211,9 @@ class DashboardRestApi(DashboardMixin,
BaseSupersetModelRestApi):
}
filter_rel_fields_field = {"owners": "first_name", "slices": "slice_name"}
- @expose("/<model_id>", methods=["PUT"])
+ @expose("/<pk>", methods=["PUT"])
Review comment:
is there some reason `model_id` was changed back to `pk`? I think `model_id`
here was nice, but if there is a convention to use `pk` then disregard.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
