robdiciuccio opened a new pull request #8946: Ensure proper JSON serialization 
of numpy.ndarray
URL: https://github.com/apache/incubator-superset/pull/8946
 
 
   ### CATEGORY
   
   Choose one
   
   - [X] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   When querying a Presto datasource with a column of type `ARRAY` 
asynchronously, the following error would be raised: 
   ```
   TypeError: Unserializable object [] of type <class 'numpy.ndarray'>
   ```
   
   This fix ensures proper conversion of the `numpy.ndarray` to a list for JSON 
serialization.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   Ensure queries against a Presto table containing nested data type columns 
work correctly. Repeat for other supported DBs having nested data type columns.
   
   This fix was tested against Presto 0.227 in both async and sync queries.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @graceguo-supercat @craig-rueda @dpgaspar @villebro 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to