dpgaspar commented on a change in pull request #8699: [SIP-29] Add support for
row-level security
URL:
https://github.com/apache/incubator-superset/pull/8699#discussion_r376714753
##########
File path: superset/connectors/sqla/views.py
##########
@@ -225,6 +225,38 @@ class SqlMetricInlineView(CompactCRUDMixin,
SupersetModelView):
edit_form_extra_fields = add_form_extra_fields
+class RowLevelSecurityFiltersModelView(SupersetModelView, DeleteMixin):
+ datamodel = SQLAInterface(models.RowLevelSecurityFilter)
+
+ list_title = _("Row level security filter")
+ show_title = _("Show Row level security filter")
+ add_title = _("Add Row level security filter")
+ edit_title = _("Edit Row level security filter")
+
+ list_columns = ["table", "roles", "clause", "creator", "modified"]
+ order_columns = ["modified"]
Review comment:
small improvement: order_columns = ["table.table_name", "clause", "modified"]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
