willbarrett commented on a change in pull request #9129: [datasets] new, API using command pattern URL: https://github.com/apache/incubator-superset/pull/9129#discussion_r379123750
########## File path: tests/dataset_api_tests.py ########## @@ -0,0 +1,445 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Unit tests for Superset""" +import json +from typing import List +from unittest.mock import patch + +import prison + +from superset import db, security_manager +from superset.connectors.sqla.models import SqlaTable +from superset.models.core import Database +from superset.utils.core import get_example_database + +from .base_tests import SupersetTestCase + + +class DatasetApiTests(SupersetTestCase): Review comment: I like the idea of partial integration tests at this layer, but I wonder if this is the best testing approach? We could easily segment out the testing such that we test the commands, DAOs, and endpoints in isolation, as they all have public interfaces. I suspect that approach would make the separation of concerns clearer and lead to more comprehensive unit tests. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
