ktmud opened a new pull request #9215: fix: choose language link for local dev
URL: https://github.com/apache/incubator-superset/pull/9215
 
 
   ### CATEGORY
   
   - [x] Bug Fix
   
   ### SUMMARY
   
   @superset-ui/connection will [add protocol and 
host](https://github.com/apache-superset/superset-ui/blob/245db6ef79de7e8f95da39ec9e2af4022418525e/packages/superset-ui-connection/src/SupersetClientClass.ts#L155-L171
   ) to an "endpoint" call. `e.currentTarget.href` may return the full URL 
instead of the relative url. This sometimes results in invalid URLs for change 
language API calls.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   In local dev environment, change language will result in a 404 error:
   
   
![Snip20200226_6](https://user-images.githubusercontent.com/335541/75408262-165c3080-58ca-11ea-85c9-be84b78a6b9e.png)
   
   
![image](https://user-images.githubusercontent.com/335541/75408229-fc225280-58c9-11ea-876b-34e2632998b2.png)
   
   The result should be gone after this fix.
   
   ### TEST PLAN
   
   Change language in local dev box will work and should not throw an error in 
the browser console.
   
   ### ADDITIONAL INFORMATION
   
   N/A
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to