asif-ir opened a new pull request #9291: [SIP-36] Migrate RunQueryActionButton.jsx to RunQueryActionButton.tsx… URL: https://github.com/apache/incubator-superset/pull/9291 … (#9290) ### CATEGORY Choose one - [ ] Bug Fix - [x] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### ADDITIONAL INFORMATION I performed the following steps: - Renamed the component file from .jsx to .tsx - No further typedefs were needed - Replaced the propTypes const with an interface Props definition - Moved default props into the default arguments within the React component - Resolved any type errors that may have been exposed by the migration - Ran tests, coverage and linting and made sure everything was good + Added more optional proptypes in Button.jsx, dummy comments in empty functions to remove linting errors. Further linting showed no errors (except pre prevalent warnings) - Also tested manually from the superset UI. Funtionality remains same for this and all other buttons. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS to: @graceguo-supercat @nytai @rusackas @kristw Will migrate more files if this is acceptable.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
