nytai commented on a change in pull request #9338: [SQLLAB] add feature flag to
disable auto-complete
URL:
https://github.com/apache/incubator-superset/pull/9338#discussion_r395936852
##########
File path: superset-frontend/src/SqlLab/components/AceEditorWrapper.tsx
##########
@@ -34,41 +33,44 @@ import {
const langTools = ace.acequire('ace/ext/language_tools');
-const propTypes = {
- actions: PropTypes.object.isRequired,
- onBlur: PropTypes.func,
- sql: PropTypes.string.isRequired,
- schemas: PropTypes.array,
- tables: PropTypes.array,
- functionNames: PropTypes.array,
- extendedTables: PropTypes.array,
- queryEditor: PropTypes.object.isRequired,
- height: PropTypes.string,
- hotkeys: PropTypes.arrayOf(
- PropTypes.shape({
- key: PropTypes.string.isRequired,
- descr: PropTypes.string.isRequired,
- func: PropTypes.func.isRequired,
- }),
- ),
- onChange: PropTypes.func,
-};
+type HotKey = {
Review comment:
typescript conversion of this file. I'm a little unfamiliar with some of the
objects here, so there's more `any`s than I'd like
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
