nytai commented on a change in pull request #9357: Adding requirements-local.txt support URL: https://github.com/apache/incubator-superset/pull/9357#discussion_r396808918
########## File path: Dockerfile ########## @@ -114,9 +114,10 @@ ENTRYPOINT ["/usr/bin/docker-entrypoint.sh"] ###################################################################### FROM lean AS dev -COPY ./requirements-dev.txt ./docker/requirements-extra.txt /app/ +COPY ./requirements-dev.txt ./docker/requirements* /app/ USER root RUN cd /app \ - && pip install --no-cache -r requirements-dev.txt -r requirements-extra.txt + && pip install --no-cache -r requirements-dev.txt -r requirements-extra.txt \ Review comment: is there a reason to not just direct users to add extra requirements in `requirements-extra.txt`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
