villebro commented on a change in pull request #9353: Implement dttm config
URL:
https://github.com/apache/incubator-superset/pull/9353#discussion_r399215676
##########
File path: superset/connectors/sqla/models.py
##########
@@ -1073,8 +1083,34 @@ def mutator(df: pd.DataFrame) -> None:
def get_sqla_table_object(self) -> Table:
return self.database.get_table(self.table_name, schema=self.schema)
- def fetch_metadata(self, commit=True) -> None:
+ def fetch_metadata(
+ self,
+ commit=True,
+ dttm_config: Optional[Dict[str, Dict[str, str]]] = None,
+ main_dttm_col: Optional[str] = None,
+ ) -> None:
Review comment:
Is there some reason why the signature is modified? It appears we could just
as easily pick up the config params here instead of passing them from `views.py`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
