villebro commented on a change in pull request #9469: [mypy] Enforcing typing for superset.examples URL: https://github.com/apache/incubator-superset/pull/9469#discussion_r403665926
########## File path: superset/examples/helpers.py ########## @@ -41,7 +41,7 @@ misc_dash_slices: Set[str] = set() # slices assembled in a 'Misc Chart' dashboard -def update_slice_ids(layout_dict, slices): +def update_slice_ids(layout_dict: Dict[Any, Any], slices: List[Slice]) -> None: Review comment: Not necessary a change that needs to be done here, but with proper typing, we don't necessarily need to include types in names as much in the future. Here `layout_dict` -> `layout`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
