ktmud commented on a change in pull request #9474: Enable beautiful json for
dashboard metadata editor
URL:
https://github.com/apache/incubator-superset/pull/9474#discussion_r404242818
##########
File path: superset-frontend/src/dashboard/components/PropertiesModal.jsx
##########
@@ -99,7 +108,8 @@ class PropertiesModal extends React.PureComponent {
...state.values,
dashboard_title: dashboard.dashboard_title || '',
slug: dashboard.slug || '',
- json_metadata: dashboard.json_metadata || '',
+ // always reformat to pretty json at initial opening
+ json_metadata: prettyJSON(dashboard.json_metadata) || '',
Review comment:
Only reformat the initial value so not to interfere users' typing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
