etr2460 commented on a change in pull request #9337: Filter owners select by text input URL: https://github.com/apache/incubator-superset/pull/9337#discussion_r404336980
########## File path: superset/views/filters.py ########## @@ -0,0 +1,44 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from flask_appbuilder.models.filters import BaseFilter +from flask_babel import lazy_gettext + +from superset import security_manager + +# pylint: disable=too-few-public-methods + + +class FilterRelatedOwners(BaseFilter): + """ + A filter to allow searching for related owners of a resource. + + Use in the api by adding something like: + related_field_filters = { + "owners": RelatedFieldFilter("first_name", FilterRelatedOwners), + } + """ + + name = lazy_gettext("Owner") + arg_name = "owners" + + def apply(self, query, value): + user_model = security_manager.user_model + like_value = "%" + value + "%" + return query.filter( + # could be made to handle spaces between names more gracefully + (user_model.first_name + " " + user_model.last_name).ilike(like_value) Review comment: I agree that appending (while not strictly correct) is an ok way to handle first names and last names. but I still think it makes sense to include the username `or` filter, even if it might not be clear why they were included. Returning too many results is better than not returning the one you're looking for Or perhaps the select box should include both the first name last name combo and the username in parens afterwards. I think Jira uses a similar pattern so that you can search both by name and email when tagging someone. Github also does a similar thing with name/username ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
