Smilebags edited a comment on issue #7509: Example 'new visualisation' PRs no 
longer work
URL: 
https://github.com/apache/incubator-superset/issues/7509#issuecomment-610704328
 
 
   Is there any update on this? It would be really useful to have some 
documentation (even in the form of an example PR) which shows what needs to be 
added to superset to add a new visualisation.
   
   I have managed to build the `superset-ui-plugins` repository after deleting 
a few of the visualisations which were causing more trouble than it was worth 
(icicle event, word cloud and superset-ui-preset-chart-xy), and installing a 
number of unlisted dependencies (`@airbnb/lunar`, `dompurify` and 
`@types/dompurify`), this has enabled me to duplicate 
`packages/superset-ui-plugin-chart-table` to 
`packages/superset-ui-plugin-chart-new-viz`.
   
   I've then rebuilt `superset-ui-plugins`, cd'ed into the new viz folder, run 
`npm link`. After this I've returned to the main superset repo, linked the 
package and then modified 
`superset/assets/src/visualizations/presets/MainPreset.js` to ensure `new-viz` 
is being called in the same manner as the other visualisations. Webpack has no 
problem building with my new visualisation included, but it has no effect on 
what is actually available in the 'Select a visualization type' window.
   
   I can't find anywhere else that needs configuration updated and can't find 
any documentation on how to do this with the new visualisation structure. Any 
guidance would be appreciated.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to