nytai commented on a change in pull request #9462: [Dashboard] new listview 
filters
URL: 
https://github.com/apache/incubator-superset/pull/9462#discussion_r406893967
 
 

 ##########
 File path: superset-frontend/src/welcome/App.jsx
 ##########
 @@ -50,26 +55,28 @@ const store = createStore(
 );
 
 const App = () => (
-  <Provider store={store}>
-    <Router>
-      <Menu data={menu} />
-      <Switch>
-        <Route path="/superset/welcome/">
-          <Welcome user={user} />
-        </Route>
-        <Route path="/dashboard/list/">
-          <DashboardList user={user} />
-        </Route>
-        <Route path="/chart/list/">
-          <ChartList user={user} />
-        </Route>
-        <Route path="/tablemodelview/list/">
-          <DatasetList user={user} />
-        </Route>
-      </Switch>
-      <ToastPresenter />
-    </Router>
-  </Provider>
+  <ThemeProvider theme={supersetTheme}>
+    <Provider store={store}>
 
 Review comment:
   that makes sense! 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to