rusackas commented on issue #9465: Importing validators module from superset-ui URL: https://github.com/apache/incubator-superset/pull/9465#issuecomment-613229998 > > import { legacyValidateInteger, legacyValidateNumber, validateNonEmpty } from '@superset-ui/validator'; > > There is a non-legacy `validateInteger` and `validateNumber` which has the logical behavior, but will break superset because it seems to expect the wrong output from the legacy functions at the moment. > > You should use `legacyValidateInteger` and `legacyValidateNumber`. > > [apache-superset/superset-ui#322](https://github.com/apache-superset/superset-ui/pull/322) > > I'll move these note into the package `README` Ahhh, thanks. Didn't catch the intent. I'll see about unifying those, as I don't love the idea of moving forward with "legacy" things in a refactor project, but it seems CI is green, yay! If you don't mind giving this a review, that'd be wonderful. Thanks, -e-
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
