willbarrett commented on a change in pull request #9944:
URL:
https://github.com/apache/incubator-superset/pull/9944#discussion_r445162640
##########
File path: superset/app.py
##########
@@ -379,6 +383,17 @@ def init_views(self) -> None:
icon="fa-search",
)
+ if self.config["ENABLE_ALERTS"]:
Review comment:
Should this be a config flag or a feature flag?
##########
File path: superset/tasks/schedules.py
##########
@@ -79,11 +86,13 @@ def _get_recipients(
def _deliver_email(
- schedule: Union[DashboardEmailSchedule, SliceEmailSchedule],
+ schedule: Union[DashboardEmailSchedule, SliceEmailSchedule, Alert],
subject: str,
email: EmailContent,
) -> None:
for (to, bcc) in _get_recipients(schedule):
+ logging.info("Sending email to [%s] bcc [%s]", to, bcc)
Review comment:
Let's not write email addresses to logs. This is protected information
in most organizations.
##########
File path: superset/charts/schemas.py
##########
@@ -27,9 +27,22 @@
# RISON/JSON schemas for query parameters
#
get_delete_ids_schema = {"type": "array", "items": {"type": "integer"}}
+width_heiht_schema = {
Review comment:
nit: typo - should be `width_height_schema`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
