ktmud commented on a change in pull request #10485:
URL:
https://github.com/apache/incubator-superset/pull/10485#discussion_r463270072
##########
File path: .github/workflows/caches.js
##########
@@ -40,7 +40,7 @@ module.exports = {
},
npm: {
path: [`${homeDirectory}/.npm`],
- hashFiles: ['superset-frontend/package-lock.json'],
+ hashFiles: [`${workspaceDirectory}/superset-frontend/package-lock.json`],
Review comment:
This cache was disabled but we are keeping the configuration anyway, in
case there are other ways to make cache loading faster in the future.
The change here is to make sure we hash the same files wherever the cache
step runs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
