villebro opened a new pull request #10661:
URL: https://github.com/apache/incubator-superset/pull/10661


   ### SUMMARY
   Currently the MySQL type `LONGTEXT` is flagged as `is_numeric` due to the 
`.*LONG.*` pattern for numeric types. This makes the generic matching rule more 
specific for `LONG` types, and adds `BIT` as a default numeric type, as it is 
commonly a numeric datatype.
   
   ### TEST PLAN
   CI + new tests. We should add similar tests to all officially supported 
databaases to ensure column types are flagged correctly.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: closes #10660 
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   FYI: @abhishekkumaresan


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to