riahk commented on a change in pull request #10668: URL: https://github.com/apache/incubator-superset/pull/10668#discussion_r476665538
########## File path: superset-frontend/src/common/components/Modal.tsx ########## @@ -0,0 +1,125 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import React from 'react'; +import styled from '@superset-ui/style'; +import { Modal as BaseModal } from 'src/common/components'; +import { t } from '@superset-ui/translation'; +import Button from 'src/views/CRUD/data/dataset/Button'; Review comment: Just checked, the Button in `src/views/CRUD...` above is actually using `src/common/components/Button` under the hood. So we could either move that styled button into its own file under `src/common/components` OR possibly add it as an optional style in the current `Button`? or I could move the styling into the new `Modal` component since the styling is only used in modals rn (see `AddDatasetModal`). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
