nytai commented on a change in pull request #10669: URL: https://github.com/apache/incubator-superset/pull/10669#discussion_r477588110
########## File path: superset/config.py ########## @@ -837,7 +837,7 @@ class CeleryConfig: # pylint: disable=too-few-public-methods # Enables the replacement react views for all the FAB views (list, edit, show) with # designs introduced in SIP-34: https://github.com/apache/incubator-superset/issues/8976 # This is a work in progress so not all features available in FAB have been implemented -ENABLE_REACT_CRUD_VIEWS = False +ENABLE_REACT_CRUD_VIEWS = os.environ.get("ENABLE_REACT_CRUD_VIEWS") or False Review comment: Should this be on the actual config.py or does it make more sense in the test config? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
