rusackas commented on a change in pull request #10649:
URL:
https://github.com/apache/incubator-superset/pull/10649#discussion_r479582570
##########
File path: superset-frontend/spec/helpers/theming.ts
##########
@@ -51,5 +51,5 @@ export function styledShallow(
theme: supersetTheme,
...options?.wrappingComponentProps,
},
- });
+ }).dive();
Review comment:
Before moving the `dive()` into the helper, That instance had
`dive().dive()` happening on it. I can't think of a time when we wouldn't want
to `dive()` at least once, so I added it into the helper to
reduce/reuse/recycle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
