zuzana-vej opened a new issue #10726:
URL: https://github.com/apache/incubator-superset/issues/10726


   **Is your feature request related to a problem? Please describe.**
   Currently when writing a query with an aggregation in SQL Lab (e.g. `select 
avg(my_column) from my_table`) the unnamed column is renamed as `_col0`, When 
clicking Explore to go to Chart Explore, the Presto query will fail with  
`presto error: line 3:8: Column '_col0' cannot be resolved`. 
   
   This causes the user to either think it's a **BUG** in Superset, or user 
realizes they need to go back to Explore, rename the column (`select 
avg(my_column) AS avg_my_column from my_table` , wait for the query to run 
again, and click "Explore again". 
   
   So the current user flow is:
   SQL Lab --> Explore --> User sees error --> back to SQL Lab --> Explore & it 
hopefully works
   
   Instead of:
   SQL Lab --> Explore
   
   **Describe the solution you'd like**
   There are two options really:
   (1) Renaming the column automatically, so that Explore doesn't result in 
error. This isn't necessary when displaying results in SQL Lab, only when user 
clicks on "Explore".
   
   In an ideal case, the columns return as `_col0` would be renamed based on 
some logic - for example concatenation of the aggregate function and the column 
(so `count(my_column)` can be named `count_my_column`, `avg(load_time)` could 
be `avg_load_time`. 
   
   (2) Better Error so that user can fix it before going to Explore:
   An alternative solution is to display an error message when user is trying 
to click explore and not allow user to go to Explore, forcing the user to 
update the query to add the column name. 
   
   **Describe alternatives you've considered**
   Current state isn't acceptable (looks like a bug to end user). Two options 
described in above section.
   
   **Additional context**
   Step 1:
   
![sqllab](https://user-images.githubusercontent.com/61221714/91627160-42846700-e96a-11ea-8ff5-8cf04597f359.png)
   
   Step 2 --> Error:
   
![explore](https://user-images.githubusercontent.com/61221714/91627156-39939580-e96a-11ea-8159-52449e191884.png)
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to