villebro commented on a change in pull request #10946:
URL:
https://github.com/apache/incubator-superset/pull/10946#discussion_r490593750
##########
File path: superset/connectors/sqla/models.py
##########
@@ -798,11 +799,14 @@ def _get_sqla_row_level_filters(
:returns: A list of SQL clauses to be ANDed together.
:rtype: List[str]
"""
+ filters_grouped: Dict[Union[int, str], List[str]] = defaultdict(list)
try:
- return [
-
text("({})".format(template_processor.process_template(f.clause)))
- for f in security_manager.get_rls_filters(self)
- ]
+ for filter_ in security_manager.get_rls_filters(self):
+ clause = text(
+ f"({template_processor.process_template(filter_.clause)})"
+ )
+ filters_grouped[filter_.group_key or filter_.id].append(clause)
Review comment:
if `group_key` is `None`, we should treat the filter as a unique group
that should be ANDed to the other filters (backwards compatibility).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
