[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #10936: feat(dashboards): Filter status indicators

[GitBox]

graceguo-supercat edited a comment on pull request #10936:
URL: 
https://github.com/apache/incubator-superset/pull/10936#issuecomment-707224331


   Hi @suddjian I found a few new issues to report:
   - After apply 1 filter, `Unset` group can not unfold:
   <img width="381" alt="Screen Shot 2020-10-12 at 9 21 34 AM" 
src="https://user-images.githubusercontent.com/27990562/95769240-6e368480-0c6c-11eb-8dcf-984fcec0f557.png";>
   
   - Please create a date filter with **time column/time granularity** control. 
This feature (and filter indicators) are broken in this feature branch.
   <img width="344" alt="Screen Shot 2020-10-12 at 9 24 16 AM" 
src="https://user-images.githubusercontent.com/27990562/95769569-f1f07100-0c6c-11eb-8953-ec3dae9087ec.png";>
   
   
   - Focus/blue filter field behavior is not consistent:
   
![qQHU9eFTxC](https://user-images.githubusercontent.com/27990562/95769754-38de6680-0c6d-11eb-9cd7-6fc1e76d9176.gif).
 Charts still be highlighted after user click "APPLY" button. And filter box 
itself (with the focused filter field), should not be highlighted, because it 
won't be applied by its own filter_field.
   
   I had seen these issues when i implemented the last version of filter 
indicators, but currently some of useful code was removed. The system was a 
little complicated for a reason :)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org