john-bodley opened a new pull request #11315: URL: https://github.com/apache/incubator-superset/pull/11315
### SUMMARY Per the SQLAlchemy default dialect it seems that the [`do_ping`](https://github.com/sqlalchemy/sqlalchemy/blob/master/lib/sqlalchemy/engine/default.py#L625-L639) method will raise only if the ping failed via a non-disconnect. This PR ensures that if the ping fails (either via raising an error or returning `False`) that the test connection also fails. Additionally it seems that the `do_ping` could raise a number of DBAPI exceptions and thus I thought there was merit in catching a broader exception. <!--- Describe the change below, including rationale and design decisions --> ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TEST PLAN CI. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
