etr2460 opened a new pull request #11837: URL: https://github.com/apache/incubator-superset/pull/11837
### SUMMARY In https://github.com/apache/incubator-superset/issues/11813 I noticed that the avatar text sizes weren't very consistent due to the varying size of 2 characters in English ("II" is much thinner than "WW"). After playing around more with the Avatar component, I realized this was because we were setting a much larger size than necessary for the Avatar text (21px). I reduced this to 14px, what seemed to be a happy medium between the 21px that "II" could fit in and the tiny 9px that "WW" needed to fully fit. It doesn't entirely fix the problem, but I think it's the best we'll get, unless we decided to make these monospaced (something that I considered a worse option). I also refactored the style application code a bit to adhere to DRY ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before:  After:  ### TEST PLAN Test in storybook with initials `II` and `WW`. Also ensure ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: Fixes https://github.com/apache/incubator-superset/issues/11813 - [x] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API to: @nytai ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
