geido commented on a change in pull request #12200: URL: https://github.com/apache/incubator-superset/pull/12200#discussion_r549320115
########## File path: superset-frontend/src/common/components/Card.tsx ########## @@ -0,0 +1,46 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import React, { FunctionComponent } from 'react'; +// eslint-disable-next-line no-restricted-imports +import { Card as AntdCard } from 'antd'; + +interface CardProps extends React.Component { + style: React.CSSProperties; + bodyStyle: React.CSSProperties; +} + +const Card: FunctionComponent<CardProps> = ({ style, bodyStyle, children }) => { Review comment: I think we are trying to enhance the Antdesign components using Emotion wherever is possible. Please have a look at common/components/Badge or common/components/Collapse for some examples of that ########## File path: superset-frontend/src/common/components/Card.tsx ########## @@ -0,0 +1,46 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import React, { FunctionComponent } from 'react'; +// eslint-disable-next-line no-restricted-imports +import { Card as AntdCard } from 'antd'; + +interface CardProps extends React.Component { Review comment: You could import the CardProps directly from antd/lib/card and extend those instead ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
