junlincc edited a comment on pull request #12552: URL: https://github.com/apache/superset/pull/12552#issuecomment-761954417
thanks for the fix! @zhaoyongjie, all changes LGTM! Question: when i type '3' in the box, the modal populates 2021-01-03, with 3 as date. vs. when i type in '40', modal takes it as year... what's the logic behind? should we consider both as unclear input and prompt users to be more specific before generating a time range as well? <img width="933" alt="Screen Shot 2021-01-17 at 6 14 48 PM" src="https://user-images.githubusercontent.com/67837651/104868888-0e95e800-58f1-11eb-8e9e-a6a53e6a7bd0.png";> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/67837651/104868888-0e95e800-58f1-11eb-8e9e-a6a53e6a7bd0.png"](https://user-images.githubusercontent.com/67837651/104868888-0e95e800-58f1-11eb-8e9e-a6a53e6a7bd0.png"){kind=link}