villebro commented on a change in pull request #12602:
URL: https://github.com/apache/superset/pull/12602#discussion_r560267275
##########
File path: superset/db_engine_specs/elasticsearch.py
##########
@@ -46,3 +46,18 @@ def convert_dttm(cls, target_type: str, dttm: datetime) ->
Optional[str]:
if target_type.upper() == utils.TemporalType.DATETIME:
return f"""CAST('{dttm.isoformat(timespec="seconds")}' AS
DATETIME)"""
return None
+
+
+class OpenDistro(ElasticSearchEngineSpec):
+
+ _time_grain_expressions = {
+ None: "{col}",
+ }
+
+ engine = "odelasticsearch"
+ engine_name = "ElasticSearch"
+
+ @classmethod
+ def make_label_compatible(cls, label: str) -> str:
+ new_label = super().make_label_compatible(label)
+ return new_label.replace(".", "_")
Review comment:
Instead of overriding `make_label_compatible`, we should define a custom
`_mutate_label` method that does this. See e.g.
https://github.com/apache/superset/blob/9771b82c947193f533ea0720c212175135118daa/superset/db_engine_specs/bigquery.py#L113-L135
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
