nytai commented on a change in pull request #12754:
URL: https://github.com/apache/superset/pull/12754#discussion_r565572526
##########
File path: .github/workflows/pr-lint.yml
##########
@@ -19,7 +19,7 @@ jobs:
submodules: recursive
- uses: ./.github/actions/pr-lint-action
with:
- title-regex:
"^(build|chore|ci|docs|feat|fix|perf|refactor|style|test|other)((.+))?:\\s.+"
+ title-regex:
"^(build|chore|ci|docs|feat|fix|perf|refactor|style|test|other)(\\(.+\\))?(\\!)?:\\s.+"
Review comment:
Ok, this is making more sense now. Looks like there's some yaml escaping
in here too. I'm seeing there was a mistake in the original parens, so the
previous regex allowed anything after the prefix and before the `:`, so
`buildskjdsfsdfsdbjfds: dsfds` would have been valid 🤣. The last `\s` is the
ensure there's white space after the `:`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
