ktmud commented on a change in pull request #12772:
URL: https://github.com/apache/superset/pull/12772#discussion_r566350126
##########
File path: superset-frontend/src/SqlLab/components/TabbedSqlEditors.jsx
##########
@@ -411,7 +415,13 @@ class TabbedSqlEditors extends React.PureComponent {
hideAdd={this.props.offline}
onEdit={this.handleEdit}
addIcon={
- <Tooltip id="add-tab" placement="bottom" title="New tab (Ctrl + t)">
+ <Tooltip
+ id="add-tab"
+ placement="bottom"
+ title={
+ userOS === 'Windows' ? 'New tab (Ctrl + q)' : 'New tab (Ctrl +
t)'
Review comment:
Could use i18n here.
```suggestion
userOS === 'Windows' ? t('New tab (Ctrl + q)') : t('New tab
(Ctrl + t)')
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
