ktmud edited a comment on pull request #12782: URL: https://github.com/apache/superset/pull/12782#issuecomment-770119750
I guess I got a little concerned when you said this is the end of this project: ``` end state of this project - reset/clear/uncheck all query and customize control when dataset is changed - In the change dataset warning msg, add a line to notify users all the current control settings will be cleared by changing dataset. ``` Rather than resetting everything to default, I think it makes more sense to just reset `SelectControl`, `MetricsControl` and `AdhocFilterControl` to their default state. Because if the end goal is to retain control values for other controls, we already don't have to do anything special about them. The select controls are trickier because you need to check column validity. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
