etr2460 opened a new pull request #12960: URL: https://github.com/apache/superset/pull/12960
### SUMMARY We ran into some data accuracy issues in our environment where time range filters wouldn't apply to certain charts (like Big Number) when set on a dashboard. We determined that this was because these charts somehow didn't have a granularity param set on them, so the time range wasn't appropriately set on the chart query. This was especially dangerous, because the chart showed as applying the filter, but it wasn't actually applied to the query. The fix is this db migration that adds the granularity param onto charts that should have one but don't. ### TEST PLAN Before the migration, see big number charts without the granularity or granularity_sqla param not filter by time range correctly. Run the migration, and see the dashboard perform the filter appropriately. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [x] Requires DB Migration. - [x] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API to: @john-bodley @ktmud @graceguo-supercat @villebro cc: @junlincc ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
