Xiao-zhen-Liu commented on code in PR #4006:
URL: https://github.com/apache/texera/pull/4006#discussion_r2475950083
##########
common/workflow-operator/src/main/scala/org/apache/amber/operator/visualization/dumbbellPlot/DumbbellPlotOpDesc.scala:
##########
@@ -46,34 +47,39 @@ class DumbbellPlotOpDesc extends PythonOperatorDescriptor {
@JsonSchemaTitle("Category Column Name")
@JsonPropertyDescription("the name of the category column")
@AutofillAttributeName
+ @NotNull(message = "Category Column Name cannot be empty")
var categoryColumnName: String = ""
@JsonProperty(value = "dumbbellStartValue", required = true)
@JsonSchemaTitle("Dumbbell Start Value")
@JsonPropertyDescription("the start point value of each dumbbell")
+ @NotBlank(message = "Dumbbell Start Value cannot be empty")
Review Comment:
Why does this one need to be `NotBlank` while most other values in this PR
are `NotNull`? What is the criteria?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
