Yicong-Huang commented on PR #3947: URL: https://github.com/apache/texera/pull/3947#issuecomment-3564265294
sorry I think I will have to -1 on this. I am concerned about the naming `permission` as well as its design. I thought in another context, in the design of access control, we want have a `permission` relationship from user to resources. This implementation realizes `permission`, but seems to be another definition, it is more of a boolean value configuration, true/false to all computing units. This is not consistent with our design. I suggest 1. we add `permission` to specific resource (i.e., Computing Unit) management page (if we have one or building), and for each resource, we should have a way for user to change permission to it. 2. If we want to have a global flag for admin to configure if a particular user can ssh to computing units or not, create a column called `configs BLOB` in user table, and make this `ssh accessible` as one of the json values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
