kunwp1 commented on code in PR #4100: URL: https://github.com/apache/texera/pull/4100#discussion_r2579628132
########## amber/src/main/python/core/models/schema/big_object.py: ########## @@ -0,0 +1,98 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +BigObject represents a reference to a large object stored externally (e.g., S3). +This is a schema type class used throughout the system for handling +BIG_OBJECT attribute types. +""" + +from typing import Optional +from urllib.parse import urlparse + + +class BigObject: Review Comment: Sounds good. In the future, we are planning to extend the binary type and let the system decide whether to offload it to S3 or not, so I think changing the name to `LargeBinary` aligns with this plan. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
