seongjinyoon commented on PR #4143: URL: https://github.com/apache/texera/pull/4143#issuecomment-3698178411
> ### What changes were proposed in this PR? > This PR fixes a permission issue where users with READ access to a workflow could not revoke their own access. > > **Changes:** > > * Updated `revokeAccess()` method in `WorkflowAccessResource.scala` to allow users to revoke their own access regardless of privilege level (READ or WRITE). > * Added owner protection which prevents workflow owners from revoking their own access to avoid orphaned workflows. > > **Before:** > > * Backend requires WRITE privilege for self-revocation. > * READ users received error when revoking their own access. > > **After:** > > * READ users can revoke their own access to a shared workflow (leave shared workflows). > * Owners cannot revoke their own access (prevent orphaned workflows). > > **Demo:** > > Screen.Recording.2025-12-29.at.6.13.00.PM.mov > ### Any related issues, documentation, discussions? > Fixes #4141. > > ### How was this PR tested? > Manually tested. > > ### Was this PR authored or co-authored using generative AI tooling? > No. > Thanks for the PR. A few comments: > > 1. In the video the user clicked the share button for the computing unit. If so, I think it should show something related to a workflow. > 2. Can we add some test cases to replace manual testing? For 1. In the video, the user clicks on the share button for the workflow. For 2. I will add test cases for this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
