xuang7 commented on code in PR #4136:
URL: https://github.com/apache/texera/pull/4136#discussion_r2658733212
##########
common/workflow-core/src/main/scala/org/apache/texera/amber/core/storage/util/LakeFSStorageClient.scala:
##########
@@ -358,4 +358,11 @@ object LakeFSStorageClient {
branchesApi.resetBranch(repoName, branchName, resetCreation).execute()
}
+ def parsePhysicalAddress(address: String): (String, String) = {
+ // expected: "<scheme>://bucket/key..."
+ val uri = new java.net.URI(address)
+ val bucket = uri.getHost
+ val key = uri.getPath.stripPrefix("/")
+ (bucket, key)
Review Comment:
Maybe consider cases where address is invalid, or the URL is missing
components (host/bucket).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
