chenlica commented on code in PR #4136:
URL: https://github.com/apache/texera/pull/4136#discussion_r2659460860
##########
file-service/src/test/scala/org/apache/texera/service/MockLakeFS.scala:
##########
@@ -87,11 +99,44 @@ trait MockLakeFS extends ForAllTestContainer with
BeforeAndAfterAll { self: Suit
def lakefsBaseUrl: String =
s"http://${lakefs.host}:${lakefs.mappedPort(8000)}"
def minioEndpoint: String = s"http://${minio.host}:${minio.mappedPort(9000)}"
+ def lakefsApiBasePath: String = s"$lakefsBaseUrl/api/v1"
Review Comment:
ok
##########
file-service/src/test/scala/org/apache/texera/service/MockLakeFS.scala:
##########
@@ -58,9 +65,14 @@ trait MockLakeFS extends ForAllTestContainer with
BeforeAndAfterAll { self: Suit
s"postgresql://${postgres.username}:${postgres.password}" +
s"@${postgres.container.getNetworkAliases.get(0)}:5432/${postgres.databaseName}"
+
s"?sslmode=disable"
+
val lakefsUsername = "texera-admin"
+
+ // These are the API credentials created/used during setup.
+ // In lakeFS, the access key + secret key are used as basic-auth
username/password for the API.
val lakefsAccessKeyID = "AKIAIOSFOLKFSSAMPLES"
Review Comment:
I know it's not part of this PR. But it is a bad idea to keep such keys in
a public codebase?
##########
common/workflow-core/src/main/scala/org/apache/texera/amber/core/storage/util/LakeFSStorageClient.scala:
##########
@@ -358,4 +359,47 @@ object LakeFSStorageClient {
branchesApi.resetBranch(repoName, branchName, resetCreation).execute()
}
+
+ /**
+ * Parse a physical address URI of the form "<scheme>://<bucket>/<key...>"
into (bucket, key).
+ *
+ * Expected examples:
+ * - "s3://my-bucket/path/to/file.csv"
Review Comment:
OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
