xuang7 commented on code in PR #4177:
URL: https://github.com/apache/texera/pull/4177#discussion_r2726128321
##########
file-service/src/main/scala/org/apache/texera/service/resource/DatasetResource.scala:
##########
@@ -175,6 +176,47 @@ object DatasetResource {
normalized
}
+ /**
+ * Converts LakeFS ApiException to appropriate HTTP exception
+ */
+ private def handleLakeFSException(e: io.lakefs.clients.sdk.ApiException):
Nothing = {
+ val rawBody =
Option(e.getResponseBody).filter(_.nonEmpty).getOrElse(e.getMessage)
+
+ val message =
+ Try(new
ObjectMapper().readTree(rawBody).get("message").asText()).getOrElse(rawBody)
+
+ def errorResponse(status: Int): Response =
+ Response
+ .status(status)
+ .entity(Map("message" -> message).asJava)
+ .`type`(MediaType.APPLICATION_JSON)
+ .build()
+
+ throw (e.getCode match {
+ case 400 => new BadRequestException(errorResponse(400))
+ case 401 => new NotAuthorizedException(errorResponse(401))
+ case 403 => new ForbiddenException(errorResponse(403))
+ case 404 => new NotFoundException(errorResponse(404))
+ case 409 => new WebApplicationException(errorResponse(409))
+ case 410 => new WebApplicationException(errorResponse(410))
+ case 412 => new WebApplicationException(errorResponse(412))
+ case 416 => new WebApplicationException(errorResponse(416))
+ case 420 => new WebApplicationException(errorResponse(420))
+ case _ => new InternalServerErrorException(errorResponse(500))
+ })
Review Comment:
Good point. For now we're using a small fallback map for the common LakeFS
status codes, which are fairly stable. Please let me know if you’d recommend
dynamically extracting codes from the ApiException instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
