kunwp1 commented on code in PR #4205:
URL: https://github.com/apache/texera/pull/4205#discussion_r2796088342


##########
amber/src/main/scala/org/apache/texera/amber/engine/architecture/controller/promisehandlers/QueryWorkerStatisticsHandler.scala:
##########


Review Comment:
   I wanted the `runtime-statistics-interval` to be independent from the 
existing `status-update-interval` and consider the case where 
`runtime-statistics-interval` is smaller than `status-update-interval`. But if 
we make an assumption that the `RuntimeStatisticsPersist` will always coincide 
with `ExecutionStatsUpdate`, the implementation would be much simpler and we 
can discard `RuntimeStatisticsPersist`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to