parshimers commented on code in PR #4219:
URL: https://github.com/apache/texera/pull/4219#discussion_r2825103976


##########
.github/workflows/build-and-push-images.yml:
##########
@@ -421,7 +446,16 @@ jobs:
       - name: Set up Docker Buildx
         uses: 
docker/setup-buildx-action@e468171a9de216ec08956ac3ada2f0791b6bd435 # v3.11.1
 
+      - name: Log in to GitHub Container Registry

Review Comment:
   This is the safe way to do this, right? So the build can't see these 
secrets? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to