kunwp1 commented on code in PR #4255:
URL: https://github.com/apache/texera/pull/4255#discussion_r2881795808
##########
bin/single-node/docker-compose.yml:
##########
@@ -235,15 +235,15 @@ services:
example-data-loader:
image: alpine:latest
depends_on:
- texera-web-application:
+ dashboard-service:
condition: service_healthy
file-service:
condition: service_healthy
volumes:
- ./examples:/examples:ro
environment:
- - TEXERA_WEB_APPLICATION_URL=http://texera-web-application:8080/api
Review Comment:
How difficult it is to change the name `TEXERA_WEB_APPLICATION_URL` to
something like `TEXERA_DASHBOARD_SERVICE_URL` or `DASHBOARD_SERVICE_URL`? I
feel like the variable name should also be consistent with the name of the
microservice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
