gracecluvohio commented on code in PR #4323:
URL: https://github.com/apache/texera/pull/4323#discussion_r2984444335
##########
.github/workflows/automatic-email-notif-on-ddl-change.yml:
##########
@@ -43,20 +43,22 @@ jobs:
-- 'sql/updates/')
echo "sql_file=$FILE" >> $GITHUB_OUTPUT
- name: Send email
- uses: dawidd6/action-send-mail@v7
- with:
- server_address: smtp.gmail.com
- server_port: 465
- secure: true
- username: ${{secrets.NOREPLY_EMAIL_USERNAME}}
- password: ${{secrets.NOREPLY_EMAIL_PASSWORD}}
- subject: Actions Required After Pulling Latest Update
- to: [email protected]
- from: ${{ github.event.pull_request.user.login }}
- body: |
- Hi all,
- We have merged PR #${{ github.event.pull_request.number }} (${{
github.event.pull_request.html_url }}): ${{github.event.pull_request.title}}.
To incorporate the change, please apply ${{ steps.get_sql_file.outputs.sql_file
}} to your local Postgres instance and run sbt jooqGenerate to generate jooq
classes.
-
- Best,
- ${{ github.event.pull_request.user.login }}
- reply_to: [email protected]
\ No newline at end of file
+ run: |
+ curl --ssl-reqd \
+ --url "smtps://smtp.gmail.com:465" \
+ --user "${{ secrets.NOREPLY_EMAIL_USERNAME }}:${{
secrets.NOREPLY_EMAIL_PASSWORD }}" \
+ --mail-from "${{ secrets.NOREPLY_EMAIL_USERNAME }}" \
+ --mail-rcpt "[email protected]" \
+ --upload-file - <<EOF
+ From: ${{ secrets.NOREPLY_EMAIL_USERNAME }}
+ To: [email protected]
+ Reply-To: [email protected]
Review Comment:
Yes, according to this comment
https://github.com/apache/texera/pull/4250#issuecomment-4006376469 it's a good
practice to make the Reply-To address the dev list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
