Ma77Ball commented on code in PR #4375:
URL: https://github.com/apache/texera/pull/4375#discussion_r3083060802
##########
common/workflow-operator/src/main/scala/org/apache/texera/amber/operator/source/scan/csv/ParallelCSVScanSourceOpDesc.scala:
##########
@@ -56,7 +56,7 @@ class ParallelCSVScanSourceOpDesc extends ScanSourceOpDesc {
executionId: ExecutionIdentity
): PhysicalOp = {
// fill in default values
- if (customDelimiter.get.isEmpty) {
+ if (customDelimiter.isEmpty || customDelimiter.get.isEmpty) {
Review Comment:
I would suggest using customDelimiter.forall or exists here instead of the
two explicit checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
